Skip to content

[Misc][UI] Allow using --kv-cache-dtype kebab-case flag #1597

Merged
valarLip merged 5 commits into
ROCm:mainfrom
simondanielsson:fix/kv-cache-dtype-flag
Jul 16, 2026
Merged

[Misc][UI] Allow using --kv-cache-dtype kebab-case flag #1597
valarLip merged 5 commits into
ROCm:mainfrom
simondanielsson:fix/kv-cache-dtype-flag

Conversation

@simondanielsson

@simondanielsson simondanielsson commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Motivation

Currently you need to use the somewhat unconventional case --kv_cache_dtype, while every other argument in ATOM is kebab case.

Keep the old one for backwards compatibility.

Note: in the docs there are still lots of uses of the old version. Let's see when/if we want to rename those as well.

Technical Details

N/A

Test Plan

pytest tests/test_arg_utils_spec.py

Test Result

...
tests/test_arg_utils_spec.py .......                                                                                                                                      [100%]

=============================================================================== 7 passed in 0.03s ===============================================================================

Submission Checklist

Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com>
@simondanielsson
simondanielsson marked this pull request as ready for review July 14, 2026 13:22
@simondanielsson

Copy link
Copy Markdown
Contributor Author

@ZhangLirong-amd Could I please request a review on this PR? Thanks

@simondanielsson simondanielsson changed the title [Bugfix] Allow using --kv-cache-dtype kebab-case flag [Misc][UI] Allow using --kv-cache-dtype kebab-case flag Jul 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1597 --add-label <label>

@zufayu
zufayu requested a review from yitingw1 July 15, 2026 02:20
@valarLip
valarLip merged commit aaad526 into ROCm:main Jul 16, 2026
1 check failed
@simondanielsson
simondanielsson deleted the fix/kv-cache-dtype-flag branch July 16, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants