Skip to content

Avoid cancelling heavy CI on review events#1590

Open
gyohuangxin wants to merge 1 commit into
mainfrom
gyohuangxin/review-ci-concurrency
Open

Avoid cancelling heavy CI on review events#1590
gyohuangxin wants to merge 1 commit into
mainfrom
gyohuangxin/review-ci-concurrency

Conversation

@gyohuangxin

Copy link
Copy Markdown
Member

Summary

  • limit heavy CI workflow cancellation to pull_request events only
  • prevent review approval/comment events from cancelling in-progress heavy CI runs

Notes

  • This is the first-step change only. It does not add an approval de-duplication gate.

Testing

  • Parsed updated workflow YAML files with Python yaml.safe_load
  • Ran git diff --check

Copilot AI review requested due to automatic review settings July 14, 2026 08:08
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1590 --add-label <label>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts GitHub Actions concurrency behavior so that in-progress heavy CI runs are only auto-cancelled for pull_request-triggered runs, preventing pull_request_review events (e.g., approvals/comments) from cancelling active heavy CI.

Changes:

  • Updated concurrency.cancel-in-progress in heavy CI workflows to cancel-in-progress: ${{ github.event_name == 'pull_request' }}.
  • Ensured pull_request_review-triggered workflow runs will no longer cancel ongoing heavy CI runs (they will queue instead, due to shared concurrency groups).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/atom-vllm-test.yaml Limits cancellation to pull_request events so review submissions won’t cancel an active vLLM heavy CI run.
.github/workflows/atom-test.yaml Limits cancellation to pull_request events so review submissions won’t cancel an active core ATOM heavy CI run.
.github/workflows/atom-sglang-test.yaml Limits cancellation to pull_request events so review submissions won’t cancel an active SGLang heavy CI run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants