Avoid cancelling heavy CI on review events#1590
Open
gyohuangxin wants to merge 1 commit into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every eligible PR before approval:
Heavy model tests:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts GitHub Actions concurrency behavior so that in-progress heavy CI runs are only auto-cancelled for pull_request-triggered runs, preventing pull_request_review events (e.g., approvals/comments) from cancelling active heavy CI.
Changes:
- Updated
concurrency.cancel-in-progressin heavy CI workflows tocancel-in-progress: ${{ github.event_name == 'pull_request' }}. - Ensured
pull_request_review-triggered workflow runs will no longer cancel ongoing heavy CI runs (they will queue instead, due to shared concurrency groups).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/atom-vllm-test.yaml | Limits cancellation to pull_request events so review submissions won’t cancel an active vLLM heavy CI run. |
| .github/workflows/atom-test.yaml | Limits cancellation to pull_request events so review submissions won’t cancel an active core ATOM heavy CI run. |
| .github/workflows/atom-sglang-test.yaml | Limits cancellation to pull_request events so review submissions won’t cancel an active SGLang heavy CI run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Testing