Skip to content

Reuse inner allocation in collect_bicolor_runs #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakelishman merged 1 commit into from
Apr 17, 2026
Merged

Reuse inner allocation in collect_bicolor_runs #1578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions rustworkx-core/src/dag_algo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,17 +588,15 @@ where
};
}

let mut colors = Vec::new();
for node in nodes {
if let Some(is_match) = filter_fn(node)? {
colors.clear();
let raw_edges = graph.edges_directed(node, petgraph::Direction::Outgoing);

// Remove all edges that yield errors from color_fn
let colors = raw_edges
.map(|edge| color_fn(edge.id()))
.collect::<Result<Vec<Option<usize>>, _>>()?;

// Remove null edges from color_fn
let colors = colors.into_iter().flatten().collect::<Vec<usize>>();
for color in raw_edges.filter_map(|edge| color_fn(edge.id()).transpose()) {
colors.push(color?);
}

match (colors.len(), is_match) {
(1, true) => {
Expand Down Expand Up @@ -638,13 +636,13 @@ where
}
}
_ => {
for color in colors {
ensure_vector_has_index!(pending_list, block_id, color);
if let Some(color_block_id) = block_id[color] {
block_list[color_block_id].append(&mut pending_list[color]);
for color in &colors {
ensure_vector_has_index!(pending_list, block_id, *color);
if let Some(color_block_id) = block_id[*color] {
block_list[color_block_id].append(&mut pending_list[*color]);
}
block_id[color] = None;
pending_list[color].clear();
block_id[*color] = None;
pending_list[*color].clear();
}
}
}
Expand Down
Loading