Fix ConstrainedReschedule barrier handling#16151
Open
TSS99 wants to merge 2 commits intoQiskit:mainfrom
Open
Conversation
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 25501265948Coverage increased (+0.05%) to 87.682%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions36 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ConstrainedRescheduleso compiler directives such as barriers are not rejected during rescheduling. Fix #16135.Details
The Rust implementation now treats directives as unconstrained operations, matching the pass documentation and the previous Python behavior. Unknown non-directive operations still raise the existing error.
Tests
.venv/bin/python reproducer_issue_16135.py.venv/bin/python -m unittest test.python.transpiler.test_scheduling_padding_pass.TestSchedulingAndPaddingPass.test_constrained_reschedule_accepts_barrier.venv/bin/python -m unittest test/python/transpiler/test_scheduling_padding_pass.py.venv/bin/black --check test/python/transpiler/test_scheduling_padding_pass.py.venv/bin/ruff check test/python/transpiler/test_scheduling_padding_pass.pycargo fmt --checkcargo clippy -p qiskit-transpiler --lib --features cache_pygates -- -D warnings.venv/bin/reno -q lintNotes
Full test suite and full
tox -elintwere not run.I reviewed the diff and can explain the changed condition and regression test.