Use generic errors in the variable mapper and expr.#16132
Open
raynelfss wants to merge 1 commit intoQiskit:mainfrom
Open
Use generic errors in the variable mapper and expr.#16132raynelfss wants to merge 1 commit intoQiskit:mainfrom
raynelfss wants to merge 1 commit intoQiskit:mainfrom
Conversation
While in the past we relied on `PyResult` to handle all of the errors as python exceptions, we can now remove some of the dependencies in parts of our system. After some evaluation, it turns out we can use generic errors in the `VariableMapper` and `Expr` which frees us from needing python in order to use these components. This was discovered during efforts to separate `DAGCircuit`'s error messages from always using `PyErr`.
raynelfss
added
Changelog: None
Collaborator
|
One or more of the following people are relevant to this code:
|
5 tasks
Coverage Report for CI Build 25338938321Coverage increased (+0.01%) to 87.568%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While in the past we relied on
PyResultto handle all of the errors as python exceptions, we can now remove some of the dependencies in parts of our system. After some evaluation, it turns out we can use generic errors in theVariableMapperandExprwhich frees us from needing python in order to use these components.This was discovered during efforts to separate
DAGCircuit's error messages from always usingPyErr.AI/LLM disclosure