Add release note for nalgebra 2q synthesis changes#16129
Open
mtreinish wants to merge 1 commit intoQiskit:mainfrom
Open
Add release note for nalgebra 2q synthesis changes#16129mtreinish wants to merge 1 commit intoQiskit:mainfrom
mtreinish wants to merge 1 commit intoQiskit:mainfrom
Conversation
In the recently merged Qiskit#16065 we added a new release note section to highlight performance changes that weren't additions. Since that has merged for the 2.5 release the PR series migrating our internal 2q synthesis code to use nalgebra should be documented under this section for the 2.5.0 release notes. Since those PRs (Qiskit#15960 and Qiskit#15928) merged before Qiskit#16065 did there was no release note documenting this change. This commit corrects that oversight and adds the release note so we're documenting this improvement in the performance section.
mtreinish
added
documentation
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 25320065385Coverage increased (+0.02%) to 87.595%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
ShellyGarion
reviewed
May 5, 2026
| and :class:`.TwoQubitWeylDecomposer` has been updated to use the | ||
| `nalgebra <https://docs.rs/nalgebra/latest/nalgebra/>`__ library internally | ||
| for matrix storage and matrix multiplication. This was done to imporve the performance | ||
| as nalgebra offers fixed size stack allocated smakk matrix types that have |
| `nalgebra <https://docs.rs/nalgebra/latest/nalgebra/>`__ library internally | ||
| for matrix storage and matrix multiplication. This was done to imporve the performance | ||
| as nalgebra offers fixed size stack allocated smakk matrix types that have | ||
| optimized implmentations of common linear algebra functions. This has led to |
Member
There was a problem hiding this comment.
Suggested change
| optimized implmentations of common linear algebra functions. This has led to | |
| optimized implementations of common linear algebra functions. This has led to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the recently merged #16065 we added a new release note section to highlight performance changes that weren't additions. Since that has merged for the 2.5 release the PR series migrating our internal 2q synthesis code to use nalgebra should be documented under this section for the 2.5.0 release notes. Since those PRs (#15960 and #15928) merged before #16065 did there was no release note documenting this change. This commit corrects that oversight and adds the release note so we're documenting this improvement in the performance section.
AI/LLM disclosure