fix: improve SABRE layout scoring for control flow operations#16120
Open
elkadylogy03-eng wants to merge 1 commit intoQiskit:mainfrom
Open
fix: improve SABRE layout scoring for control flow operations#16120elkadylogy03-eng wants to merge 1 commit intoQiskit:mainfrom
elkadylogy03-eng wants to merge 1 commit intoQiskit:mainfrom
Conversation
The layout algorithm was treating all ControlFlow nodes as Synchronize points, ignoring qubit interactions inside if/else blocks entirely. Fix: Extract the dominant 2Q interaction from inside ControlFlow blocks using correct outer qubit mapping. Fixes Qiskit#14968
qiskit-bot
added
the
Community PR
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layout algorithm was treating all controlflow nodes as synchronize points ,ignoring qubit interaction from inside if/else blocks entirely
Fix: extract the dominant 2q interaction from inside controlflow blocks using correct outer qubit mapping
Fixes #14968
AI/LLM disclosure