Skip to content

removing pathConditionRoot from the states #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gitubrr merged 8 commits into from
Dec 26, 2025
Merged

removing pathConditionRoot from the states #98

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
95c09ec
removing pc-root from the states
Gitubrr Dec 19, 2025
c5482cb
deleted commemts
Gitubrr Dec 19, 2025
5d0edb0
made egjes between states and pc
Gitubrr Dec 23, 2025
31eb222
returned counters
Gitubrr Dec 24, 2025
cbaf95a
fixed indexes
Gitubrr Dec 25, 2025
48570e5
fixed indexes again
Gitubrr Dec 25, 2025
3a81820
replaced numOfPathConditionEdjes
Gitubrr Dec 26, 2025
156fa71
edjes -> edges
Gitubrr Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VSharp.Explorer/AISearcher.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ type internal AISearcher(oracle: Oracle, aiAgentTrainingMode: Option<AIAgentTrai
firstFreePositionInParentsOf <- firstFreePositionInParentsOf + state.Children.Length
Comment thread
gsvgit marked this conversation as resolved.

index_pcToState.[firstFreePositionInPcToState] <-
int64 pathConditionVerticesIds[state.PathCondition.Id]
int64 pathConditionVerticesIds[state.PathCondition.[firstFreePositionInPcToState]]
Copy link
Copy Markdown
Member

@gsvgit gsvgit Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks strange. You should add edges between state and all vertices in state.PathCondition.


index_pcToState.[firstFreePositionInPcToState + gameState.States.Length] <-
int64 stateIds[state.Id]
Expand Down
11 changes: 2 additions & 9 deletions VSharp.IL/Serializer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,20 +495,13 @@ let collectGameState (basicBlocks: ResizeArray<BasicBlock>) filterStates process
for term in pathCondition do
pathConditionDelta.AddRange(collectPathCondition term termsWithId processedPathConditionVertices)

let pathConditionRoot =
PathConditionVertex(
id = getFirstFreePathConditionVertexId (),
pathConditionVertexType = pathConditionVertexType.PathConditionRoot,
children = [| for p in pathCondition -> termsWithId.[p] |]
)

pathConditionDelta.Add pathConditionRoot
let children = [| for p in pathCondition -> termsWithId.[p] |]

State(
s.Id,
(uint <| s.CodeLocation.offset - currentBasicBlock.StartOffset + 1<byte_offset>)
* 1u<byte_offset>,
pathConditionRoot,
children,
s.VisitedAgainVertices,
s.VisitedNotCoveredVerticesInZone,
s.VisitedNotCoveredVerticesOutOfZone,
Expand Down
2 changes: 1 addition & 1 deletion VSharp.ML.GameServer/Messages.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ type StateHistoryElem =
type State =
val Id: uint<stateId>
val Position: uint<byte_offset> // to basic block id
val PathCondition: PathConditionVertex
val PathCondition: uint<pathConditionVertexId> array
val VisitedAgainVertices: uint
val VisitedNotCoveredVerticesInZone: uint
val VisitedNotCoveredVerticesOutOfZone: uint
Expand Down
Loading