Skip to content

fix(s3): return XML error responses for presigned POST failures #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Meemaw wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(s3): return XML error responses for presigned POST failures #13

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b8b6eb
fix(s3): return XML error responses for presigned POST failures
devin-ai-integration[bot] Apr 10, 2026
5599f03
test(s3): add raw XML wire format assertion for presigned POST errors
devin-ai-integration[bot] Apr 10, 2026
eb77dad
refactor(test): assert exact XML response with regex for RequestId
devin-ai-integration[bot] Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/java/io/github/hectorvent/floci/services/s3/S3Controller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,6 +1590,16 @@ private Instant parseHttpDate(String dateStr) {
}

private Response handlePresignedPost(String bucket, String contentType, byte[] body) {
try {
return doHandlePresignedPost(bucket, contentType, body);
} catch (AwsException e) {
// Presigned POST errors must be returned as XML (matching LocalStack/AWS),
// not JSON which is what the global AwsExceptionMapper would produce.
return xmlErrorResponse(e);
}
}

private Response doHandlePresignedPost(String bucket, String contentType, byte[] body) {
String boundary = extractBoundary(contentType);
if (boundary == null) {
throw new AwsException("InvalidArgument",
Expand Down