Skip to content

Convert MiradorShareDialog and MiradorShareEmbed to function compontents - #74

Merged
marlo-longley merged 6 commits into
mainfrom
convert-miradorsharedialog-to-function
Jul 30, 2025
Merged

Convert MiradorShareDialog and MiradorShareEmbed to function compontents#74
marlo-longley merged 6 commits into
mainfrom
convert-miradorsharedialog-to-function

Conversation

@lutzhelm

@lutzhelm lutzhelm commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@lutzhelm

lutzhelm commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

This is weird. npm actually chooses 19.1.0 for both react-dom and react, but in the v4.0.0-alpha.16 Mirador ES build, there is a very strange hardcoded version check in line 25240:

      if (a !== "19.0.0")
        throw Error(
          `Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:
  - react:      ` + (a + `
  - react-dom:  19.0.0
Learn more: https://react.dev/warnings/version-mismatch`)
        );

@marlo-longley

Copy link
Copy Markdown
Member

Confirming that this error is happening on the current main branch of the share plugin, not just this PR branch. Looking at it now...

@lutzhelm
lutzhelm force-pushed the convert-miradorsharedialog-to-function branch from 5dea644 to 4c8f819 Compare July 22, 2025 12:11
@lutzhelm
lutzhelm marked this pull request as ready for review July 22, 2025 13:08
@lutzhelm
lutzhelm marked this pull request as draft July 22, 2025 13:13
@lutzhelm lutzhelm changed the title Convert MiradorShareDialog to a function compontent Convert MiradorShareDialog and MiradorShareEmbed to function compontents Jul 22, 2025
@lutzhelm
lutzhelm marked this pull request as ready for review July 22, 2025 14:35
Comment thread src/MiradorShareDialog.js Outdated
Comment thread src/MiradorShareDialog.js Outdated
Comment thread src/MiradorShareEmbed.js Outdated
lutzhelm and others added 2 commits July 30, 2025 17:35
Co-authored-by: Marlo Longley <marlo-longley@users.noreply.github.com>
@marlo-longley
marlo-longley merged commit 5a865da into main Jul 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants