fix(profiles): remove leisure=track from foot profile routable ways#7542
Open
DennisOSRM wants to merge 2 commits intomasterfrom
Open
fix(profiles): remove leisure=track from foot profile routable ways#7542DennisOSRM wants to merge 2 commits intomasterfrom
DennisOSRM wants to merge 2 commits intomasterfrom
Conversation
leisure=track refers to a sports/race track (athletics track, velodrome, etc.) and is not intended as a walking path. Routing pedestrians over this tag was incorrect per OSM tagging conventions. Removes leisure=track from the whitelisted surface types and stops fetching the leisure key during way processing entirely. Closes #4312 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
leisure=trackfrom the foot profile's list of routable way types, fixing #4312.Problem
The foot profile was treating
leisure=trackas a walkable surface and routing pedestrians over it. However, according to the OSM wiki,leisure=trackdescribes a sports or race track (athletics track, velodrome, horse racing circuit, etc.) — not a path intended for general pedestrian use.This caused OSRM to generate routes through areas that are typically restricted to athletes/competitors, or physically unsuitable for walking (e.g., a running track around a sports field, a velodrome).
Changes
speeds.leisure.trackfrom the speeds table insetup()leisurekey lookup inprocess_way()(no other leisure tags are used by the profile)Functional Impact
Ways tagged with
leisure=trackwill no longer be considered routable by the foot profile. Pedestrians will no longer be routed through race/sports tracks.