fix(watchhub): show platform name for streaming platform sources#347
Open
lakshaygujjar273-cys wants to merge 1 commit into
Open
fix(watchhub): show platform name for streaming platform sources#347lakshaygujjar273-cys wants to merge 1 commit into
lakshaygujjar273-cys wants to merge 1 commit into
Conversation
- getSourceName() now derives platform label (Amazon Prime Video, Netflix, etc.) from externalUrl host when title/name is blank - Fixes sources list showing no platform name for WatchHub entries Fixes ProdigyV21#266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266
Problem
WatchHub addon returns streams with
externalUrlpointing to platformslike Amazon Prime Video. The sources list showed no platform name and
clicking any source showed "Playback error" because ExoPlayer cannot
play a streaming platform web page.
Fix
Updated
getSourceName()inStremioStreamto derive a human-readableplatform label (e.g. "Amazon Prime Video", "Netflix", "Disney+") from
the
externalUrlhost when the stream's title/name field is blank.Testing