Skip to content

Fix TV stream selector UI, and plugin prefixes #328

Merged
ProdigyV21 merged 4 commits into
ProdigyV21:mainfrom
test01203:fix/stream-selector-ui-improvements
Jun 8, 2026
Merged

Fix TV stream selector UI, and plugin prefixes #328
ProdigyV21 merged 4 commits into
ProdigyV21:mainfrom
test01203:fix/stream-selector-ui-improvements

Conversation

@test01203

Copy link
Copy Markdown
Contributor

This PR adds a visual down-arrow indicator to the TV Stream Selector. Previously, it wasn't working as expected, so this ensures users can clearly see when there are more items available to scroll down to. It also changes the plugin prefix to English ("Plugin:") for consistency.
Plugin Loading Names: Fixed an issue where the loading status was hardcoded to "Plugins loading..." and didn't actually display the names of the plugins being loaded. It now correctly dynamically shows the names of the active plugins.
Plugin Prefixes: Added the "Plugin:" prefix to source names that originate from plugins so they are easily identifiable in the sources list.
TV Scroll Indicator: Added a visual down-arrow indicator to the TV UI to show users when there are more items available to scroll down to.

@ProdigyV21

Copy link
Copy Markdown
Owner

Could you show some screenshots of the ui changes made and how it works? This would save me some time with manual retesting.

@test01203

Copy link
Copy Markdown
Contributor Author

Could you show some screenshots of the ui changes made and how it works? This would save me some time with manual retesting.
There was a problem searching for sources, everything is fixed now.

image

@ProdigyV21

Copy link
Copy Markdown
Owner

The source selector page had a revamp just now. See if this pr is still needed now.

@test01203

Copy link
Copy Markdown
Contributor Author

The source selector page had a revamp just now. See if this pr is still needed now.

Yes, this PR is definitely still needed! The Plugin: prefixes are very important to distinguish between plugins and standard addons in the source selector.

I have just merged main into this branch and resolved the conflicts with your new revamped Source Selector UI. It now perfectly uses your brand new UI design, while keeping the plugin prefixes feature intact.

It should be safe to merge now! Thanks! 🚀

@ProdigyV21

Copy link
Copy Markdown
Owner

A few cleanup/fix points:

  1. Please remove the accidental files Test.kt and emulator_logs.txt from the PR.
  2. git diff --check fails on trailing whitespace in DetailsViewModel.kt.
  3. The PR adds loadingPluginNames / plugins_loading, but the stream selector UI does not actually render the plugin names yet. It still shows the generic “Searching addons…” loading text.
  4. PluginSafety now allows / and \ in filenames. If this is needed for relative plugin paths, please validate/normalize the path safely instead of fully removing that guard.
  5. The ProGuard log stripping rules are commented out, which seems unrelated to this PR and should probably be reverted unless there is a specific reason.

After this I can merge

@test01203

Copy link
Copy Markdown
Contributor Author

All done!

  • Removed the accidental Test.kt and emulator_logs.txt files.
  • Fixed the trailing whitespace issue in DetailsViewModel.kt.
  • Updated the stream selector UI so it correctly passes down and renders loadingPluginNames.
  • Validated the path safely in PluginSafety.kt using path normalization, allowing relative references while preventing directory traversal escaping.
  • Reverted the commented out ProGuard rules back to how they were.

Thanks for the review, should be ready for merge now!

@ProdigyV21 ProdigyV21 merged commit a3685c6 into ProdigyV21:main Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants