client: respond to network_stack_latency packets#750
Open
VasilisDragon wants to merge 1 commit into
Open
Conversation
Author
|
Oh forgot to add. Addresses the latency-transaction kick in #643 |
extremeheat
reviewed
Jun 27, 2026
| @@ -0,0 +1,47 @@ | |||
| /* eslint-env jest */ | |||
| // them to measure latency and to detect unresponsive clients. Echo each request straight back | ||
| // with the same timestamp so the round-trip resolves. See #643. | ||
| function respondToNetworkStackLatency (client) { | ||
| client.on('network_stack_latency', (packet) => { |
Member
There was a problem hiding this comment.
This function isn't needed, it can be inlined
A vanilla client echoes network_stack_latency back to the server, but the client never did, so latency-measuring servers (and server-side anticheats that track the round-trip) see it as unresponsive and time it out. Echo each request straight back with the same timestamp.
VasilisDragon
force-pushed
the
vasilis-network-stack-latency
branch
from
June 27, 2026 19:53
509b80b to
d5d20d0
Compare
extremeheat
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vanilla client echoes network_stack_latency back to the server, but the client never did, so latency-measuring servers (and server-side anticheats that track the round-trip) see it as unresponsive and time it out. Echo each request straight back with the same timestamp.