Fix NullPointerException when Host header is lowercase#123
Open
63n0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Param Miner currently only recognizes the
Hostheader when it is written asHost:.When running Guess Headers against an HTTP/1.1 request that uses a lowercase
hostheader, the host value is not extracted correctly, which later results in aNullPointerException.This change makes the Host header lookup case-insensitive so that requests using
host:are handled correctly.Reproduction
Run Guess Headers against the following request:
The extension throws the following exception:
Root Cause
The code only checks for headers beginning with
Host::HTTP header field names are case-insensitive, so requests using
host:are not recognized. As a result, the host variable remains unset and aNullPointerExceptionoccurs later during header guessing.Fix
Perform a case-insensitive match when extracting the Host header value.