Use FileSaver.js on WASM - #268
Conversation
|
Look promising, thanks! But the UX seems to be broken after this change, the popup no longer serves any purpose as far as I can tell, shouldn't we remove it? Firefox: Screencast.From.2025-10-18.17-21-42.mp4Chrome: Screencast.From.2025-10-18.17-22-21.mp4 |
|
I think it could be removed, but if I understand correctly, |
|
It's fine we don't need cancellation, from what I've seen most people were not fans of the popup existence anyway. |
|
Now that I think about it, I think the alternative to removing it could be adding download button that would allow for triggering the download multiple times, similar to how the link worked up until this. I'm not sure what is the situation with WebKit (with downloads not being triggered outside of input handling) at the moment, but presumably better to err on the side of safety. |
Sure, that's also fine by me. Having a button also makes sure that we will be called from a click-handler, which as you mentioned can sometimes be mandatory. |
|
Awesome, I'll try to do it as soon as possible. Thanks for taking a look! |
|
Could you check if this works? |
|
Works fine now. Can you also say which browser it actually fixes? |
Use FileSaver.js on WASM to allow for default file names on "recent" versions of all major browsers (see supported browsers). I think it is related to what #128 is asking for.