Add Ohio homestead property tax exemption#8310
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8310 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 5 +3
Lines 36 71 +35
=========================================
+ Hits 36 71 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…property-tax-exemption
Program Review: Ohio Homestead Exemption (PR #8310)Source Documents
Branch Status⚠ PR branch is 8 commit(s) behind main. Consider rebasing before merging. Review was scoped to the PR's actual changes — staleness did not affect findings. Critical (Must Fix)
Should Address
Suggestions
PDF Audit Summary
Validation Summary
Review Severity: REQUEST_CHANGESTwo CRITICAL findings (income_limit TY2025 value mismatch; zero-coverage formula causing the codecov failure) require fixes before merge. The contested amount TY2026 = $29,700 should be verified against the Ohio Dept. of Taxation indexing bulletin and may escalate to CRITICAL if the county guides' $29,000 is confirmed. Next StepsTo auto-fix issues: |
hua7450
left a comment
There was a problem hiding this comment.
Requesting changes — see the detailed review comment above. Two blockers before merge:
income_limit.yamlTY2025 = $41,000 is wrong — should be $40,000 ($41,000 is the TY2026 value, applied a year early). Confirmed via code-path + 600 DPI + 5 county auditors. Fix: split 40_000@2025 / 41_000@2026, mirroringamount.yaml.oh_homestead_exemption_total_incomeformula has zero test coverage (set as a direct input everywhere) — the root cause of the failing codecov checks. Add a test that sets prior-yearoh_modified_agiand asserts the variable as an output.
Also please verify amount.yaml TY2026 = $29,700 against the Ohio Dept. of Taxation indexing bulletin — the cited fiscal note says $29,700 but 2026 county guides show $29,000; this escalates to a blocker if $29,000 is confirmed.
Summary
Closes #8200.
Tests
PYTHONPATH=. /Users/daphnehansell/Documents/GitHub/policyengine-us/.venv/bin/python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/states/oh/tax/property/homestead_exemption -c policyengine_us/Users/daphnehansell/Documents/GitHub/policyengine-us/.venv/bin/ruff check policyengine_us/variables/gov/states/oh/tax/property/homestead_exemption