[io] Support large polygons in PLY output - #6464
Draft
fallenmi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6087.
Summary
ucharface-list counts for meshes whose polygons have at most 255 verticesuintwhen any polygon is largerWhy
PLY declares one list-count type per face property. A 256-vertex polygon was previously declared as
uchar; in binary output its size was cast to zero, corrupting the following index stream. The mesh-wide choice preserves compatibility for ordinary files while making mixed small/large meshes self-consistent.Validation
master: failed on the missinguintheader and ASCII parse mismatchtest_ply_io: 74/74 passedgit diff --checkAI assistance disclosure: OpenAI Codex helped investigate and draft this change; I reproduced the bug, reviewed the patch, and ran the tests listed above.