Skip to content

[FEATURE] Add prominence score to divisions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brandon Liu (bdon) merged 1 commit into from
Jul 23, 2026
Merged

[FEATURE] Add prominence score to divisions #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions profiles/Divisions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,19 @@ public void processFeature(SourceFeature source, FeatureCollector features) {
};
if (layer.equals("division")) {
var point = features.point(layer);

// extract the cartography.prominence value
// as the @prominence tag
if (source.hasTag("cartography")) {
var cartography = source.getStruct("cartography");
var prominence = source.getStruct("cartography").get("prominence");
point.setSortKeyDescending(prominence.asInt());
// depending on the prominence, boost the minzoom higher
minzoom = Math.min((int)Math.floor((100.0 - prominence.asDouble()) / 5.0)+1,10);
point.setAttr("@prominence", prominence);
}
point.setMinZoom(minzoom);

OvertureProfile.addFullTags(source, point, minzoom);
} else if (layer.equals("division_boundary")) {
var line = features.line(layer);
Expand Down