Skip to content

Add theme definitions table to Data Guides#235

Merged
Dana Bauer (danabauer) merged 6 commits into
mainfrom
theme-definitions
Dec 11, 2025
Merged

Add theme definitions table to Data Guides#235
Dana Bauer (danabauer) merged 6 commits into
mainfrom
theme-definitions

Conversation

@FlorianNachtigall

Copy link
Copy Markdown
Member

Pull Request

Create an overview table for data themes based on the Definitions Proposal.

Proposal

  • theme-definitions.json as the single source of truth for all data theme and data type definitions that extend beyond schema specifications.
  • themesTable.js react component to render a table which can be expanded to show full definitions, while providing an aggregate view for comparing definitions and characteristics across themes.

Know issues

ToDos

  • Extract css
  • Review definition json, especially freshness, quality_assurance and filtering fields
  • Update schema with new definitions from Definitions Proposal

Docs Preview:

Click the most recent "View Deployment"

All Staging Deployments

- Added `theme-definitions.json` with structured descriptions of all
  data themes (based on the [Definitions Proposal](https://lf-overturemaps.atlassian.net/wiki/spaces/PROJ/pages/353927169/Definitions+Proposal))
- Added `theme-definitions.mdx` page under /guides to display the themes
  table
- Introduced `ThemesTable` React component for rendering and styling the
  table

Note: Theme definitions are still incomplete and may contain errors.
"url": "https://www.apache.org/licenses/LICENSE-2.0"
}
],
"sources": [

@stepps00 Stephen Epps (stepps00) Nov 20, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now maintain AllThePlaces and RenderSEO data for places and the list will continue to grow each release. Since we also have the Attribution and Licensing page and source json files (places example), would it be worth linking out to one of these lists, rather than maintain it separately here?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. I'll probably do that after we publish the initial version of this table.

Comment thread docs/guides/theme-definitions.json Outdated
Comment thread docs/guides/theme-definitions.json Outdated
"freshness": "",
"type": "commercial",
"url": ""
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have added Krick as a commercial provider

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Felix Wagner (@wagnerfe). This will be resolved when we integrate the official sources json file that Stephen Epps (@stepps00) mentioned above

- Fix license name formatting
- Update address definition (GERSified, coverage, quality)
- Correct any fields transferred incorrectly from the wiki
- Render merging summary as list
Comment thread docs/guides/theme-definitions.json Outdated
Comment thread docs/guides/theme-definitions.json Outdated
Comment thread docs/guides/theme-definitions.json Outdated
Comment thread static/theme_definitions.json
Comment thread docs/guides/theme-definitions.json Outdated
Comment thread static/theme_definitions.json
Comment thread docs/guides/theme-definitions.json Outdated
Comment thread static/theme_definitions.json
Comment thread static/theme_definitions.json
Comment thread static/theme_definitions.json
@danabauer Dana Bauer (danabauer) changed the title [WIP] Add theme definitions table to Data Guides [WIP-do not merge!] Add theme definitions table to Data Guides Dec 1, 2025
@danabauer Dana Bauer (danabauer) changed the title [WIP-do not merge!] Add theme definitions table to Data Guides Add theme definitions table to Data Guides Dec 11, 2025
@danabauer
Dana Bauer (danabauer) merged commit 902142b into main Dec 11, 2025
2 checks passed
@danabauer
Dana Bauer (danabauer) deleted the theme-definitions branch December 11, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants