Add theme definitions table to Data Guides#235
Merged
Conversation
- Added `theme-definitions.json` with structured descriptions of all data themes (based on the [Definitions Proposal](https://lf-overturemaps.atlassian.net/wiki/spaces/PROJ/pages/353927169/Definitions+Proposal)) - Added `theme-definitions.mdx` page under /guides to display the themes table - Introduced `ThemesTable` React component for rendering and styling the table Note: Theme definitions are still incomplete and may contain errors.
Florian Nachtigall (FlorianNachtigall)
force-pushed
the
theme-definitions
branch
from
October 17, 2025 15:37
b0b50da to
0509cb7
Compare
Florian Nachtigall (FlorianNachtigall)
temporarily deployed
to
staging
October 17, 2025 15:39 — with
GitHub Actions
Inactive
Dana Bauer (danabauer)
self-requested a review
October 27, 2025 12:09
| "url": "https://www.apache.org/licenses/LICENSE-2.0" | ||
| } | ||
| ], | ||
| "sources": [ |
Collaborator
There was a problem hiding this comment.
We now maintain AllThePlaces and RenderSEO data for places and the list will continue to grow each release. Since we also have the Attribution and Licensing page and source json files (places example), would it be worth linking out to one of these lists, rather than maintain it separately here?
Collaborator
There was a problem hiding this comment.
agree. I'll probably do that after we publish the initial version of this table.
| "freshness": "", | ||
| "type": "commercial", | ||
| "url": "" | ||
| } |
There was a problem hiding this comment.
we have added Krick as a commercial provider
Collaborator
There was a problem hiding this comment.
Thanks, Felix Wagner (@wagnerfe). This will be resolved when we integrate the official sources json file that Stephen Epps (@stepps00) mentioned above
- Fix license name formatting - Update address definition (GERSified, coverage, quality) - Correct any fields transferred incorrectly from the wiki - Render merging summary as list
Florian Nachtigall (FlorianNachtigall)
temporarily deployed
to
staging
November 24, 2025 18:04 — with
GitHub Actions
Inactive
Dana Bauer (danabauer)
temporarily deployed
to
staging
December 4, 2025 14:46 — with
GitHub Actions
Inactive
Dana Bauer (danabauer)
force-pushed
the
theme-definitions
branch
from
December 4, 2025 17:03
a9b4143 to
8540c19
Compare
Dana Bauer (danabauer)
temporarily deployed
to
staging
December 4, 2025 17:05 — with
GitHub Actions
Inactive
Dana Bauer (danabauer)
temporarily deployed
to
staging
December 4, 2025 19:12 — with
GitHub Actions
Inactive
Dana Bauer (danabauer)
temporarily deployed
to
staging
December 4, 2025 19:38 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Create an overview table for data themes based on the Definitions Proposal.
Proposal
theme-definitions.jsonas the single source of truth for all data theme and data type definitions that extend beyond schema specifications.themesTable.jsreact component to render a table which can be expanded to show full definitions, while providing an aggregate view for comparing definitions and characteristics across themes.Know issues
ToDos
freshness,quality_assuranceandfilteringfieldsDocs Preview:
Click the most recent "View Deployment"
All Staging Deployments