Update production_deploy_documentation.yml - #214
Merged
Conversation
Jennings Anderson (jenningsanderson)
requested review from
Copilot and
Dana Bauer (danabauer)
July 18, 2025 19:34
Jennings Anderson (jenningsanderson)
temporarily deployed
to
staging
July 18, 2025 19:34 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow for production documentation deployment by refactoring the deployment process to use GitHub's newer pages deployment actions. The changes split the workflow into separate build and deploy jobs, add better permission documentation, and replace the legacy deployment method.
- Restructured workflow from single job to separate build and deploy jobs
- Updated permissions with inline comments explaining their purpose
- Replaced JamesIves/github-pages-deploy-action with GitHub's native pages deployment actions
Comments suppressed due to low confidence (1)
.github/workflows/production_deploy_documentation.yml:65
- The step ID 'docs' is used twice in the workflow (lines 50 and 65). Step IDs should be unique within their respective jobs to avoid confusion and potential issues when referencing outputs.
id: docs
Jennings Anderson (jenningsanderson)
temporarily deployed
to
staging
July 18, 2025 19:38 — with
GitHub Actions
Inactive
Jennings Anderson (jenningsanderson)
had a problem deploying
to
github-pages
July 18, 2025 19:44 — with
GitHub Actions
Failure
Jennings Anderson (jenningsanderson)
temporarily deployed
to
staging
July 18, 2025 19:51 — with
GitHub Actions
Inactive
Dana Bauer (danabauer)
approved these changes
Jul 19, 2025
Dana Bauer (danabauer)
left a comment
Collaborator
There was a problem hiding this comment.
thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Docs Preview:
Docs preview for this PR.
View all staged runs:
https://github.com/OvertureMaps/docs/actions/workflows/publish-pr-to-staging.yml