Skip to content

Release v10.0.0-rc.19 — version bump#1245

Merged
branarakic merged 2 commits into
mainfrom
release/rc19
Jun 20, 2026
Merged

Release v10.0.0-rc.19 — version bump#1245
branarakic merged 2 commits into
mainfrom
release/rc19

Conversation

@branarakic

Copy link
Copy Markdown
Contributor

rc19 release — version bump

Version-bump PR for v10.0.0-rc.19. Cuts from current main (525004a04). Single commit: 10.0.0-rc.18 → 10.0.0-rc.19 across all 19 workspace package.json (16 public validated == rc.19 for the npm-publish gate). No code or lockfile changes.

Scope: version only. Unlike rc18, this PR does not touch contract addresses — any testnet/mainnet contract redeploy + address update is handled separately.

What rc19 contains (already merged to main since rc18)

Anti-spam / security

Scalability

Observability

Mainnet prep & stability

After merge (release process — for reference, not part of this PR)

Tag v10.0.0-rc.19npm-publish (reviewer-gated) → GitHub release → update testnet nodes + validate.

🤖 Generated with Claude Code

10.0.0-rc.18 → 10.0.0-rc.19 across all 19 workspace package.json
(16 public validated == rc.19 for the npm-publish gate).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
{
"name": "@origintrail-official/dkg-random-sampling",
"version": "10.0.0-rc.18",
"version": "10.0.0-rc.19",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug: The manifest is bumped to 10.0.0-rc.19, but this package still exports RANDOM_SAMPLING_PACKAGE_VERSION = '10.0.0-rc.2' from packages/random-sampling/src/index.ts, and its test asserts that stale value. That means the current validation would pass while the published API reports the wrong release version; update the constant or derive it from package metadata, and make the test compare against the manifest rather than a hard-coded old RC.

{
"name": "@origintrail-official/dkg-adapter-openclaw",
"version": "10.0.0-rc.18",
"version": "10.0.0-rc.19",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Bug: This published adapter package includes openclaw.plugin.json in its files list, but that shipped plugin manifest still says "version": "10.0.0-rc.2". Consumers or OpenClaw registry/update logic reading the plugin manifest will see the adapter as rc.2 even though npm installs rc.19, and there is no validation covering this secondary version field.

branarakic pushed a commit that referenced this pull request Jun 20, 2026
…ifest bump

The version-bump only updated package.json manifests; these three version
strings live outside package.json and were left at rc.2 (flagged in #1245
review):
  - packages/random-sampling/src/index.ts        RANDOM_SAMPLING_PACKAGE_VERSION
  - packages/random-sampling/test/skeleton.test.ts  (the assertion on it)
  - packages/adapter-openclaw/openclaw.plugin.json  (shipped in the package
    `files` list, so consumers/registry would otherwise read the adapter as rc.2)

Deliberately NOT changed: GOSSIP_ENVELOPE_VERSION ('10.0.0' — a wire-protocol
version decoupled from the rc release cadence) and the rc.10/rc.11 references
in code comments (historical facts).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ifest bump

The version-bump only updated package.json manifests; these three version
strings live outside package.json and were left at rc.2 (flagged in #1245
review):
  - packages/random-sampling/src/index.ts        RANDOM_SAMPLING_PACKAGE_VERSION
  - packages/random-sampling/test/skeleton.test.ts  (the assertion on it)
  - packages/adapter-openclaw/openclaw.plugin.json  (shipped in the package
    `files` list, so consumers/registry would otherwise read the adapter as rc.2)

Deliberately NOT changed: GOSSIP_ENVELOPE_VERSION ('10.0.0' — a wire-protocol
version decoupled from the rc release cadence) and the rc.10/rc.11 references
in code comments (historical facts).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@branarakic

Copy link
Copy Markdown
Contributor Author

Addressed the rc.2 version-string feedback in 44e27a139:

  • packages/random-sampling/src/index.tsRANDOM_SAMPLING_PACKAGE_VERSION10.0.0-rc.19 (and updated the assertion in test/skeleton.test.ts; the random-sampling suite is green, 65/65).
  • packages/adapter-openclaw/openclaw.plugin.jsonversion10.0.0-rc.19 (it ships in the package files list, so the OpenClaw registry / consumers would otherwise read the adapter as rc.2).

Deliberately left unchanged (flagging so it's clear it wasn't an oversight):

  • GOSSIP_ENVELOPE_VERSION = '10.0.0' in packages/core/src/proto/gossip-envelope.ts — a wire-protocol version, intentionally decoupled from the rc release cadence.
  • the rc.10 / rc.11 references in code comments (evm-adapter-conviction.ts, core-prereq-check.ts, types.ts) — historical facts, not the current version.

*/

export const RANDOM_SAMPLING_PACKAGE_VERSION = '10.0.0-rc.2';
export const RANDOM_SAMPLING_PACKAGE_VERSION = '10.0.0-rc.19';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Issue: RANDOM_SAMPLING_PACKAGE_VERSION manually duplicates the package version, and the updated test repeats the same hard-coded literal instead of checking packages/random-sampling/package.json. This creates another release-bump hotspot that can drift from the published metadata; the previous value was already stale relative to the package version. Consider deriving or generating this value from package metadata, or at least make the test compare against package.json so future bumps fail when this export is missed.

describe('@origintrail-official/dkg-random-sampling — skeleton', () => {
it('exposes a version constant matching the rest of the workspace', () => {
expect(RANDOM_SAMPLING_PACKAGE_VERSION).toBe('10.0.0-rc.2');
expect(RANDOM_SAMPLING_PACKAGE_VERSION).toBe('10.0.0-rc.19');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Issue: This test claims the exported version matches the rest of the workspace, but it only compares the source constant to another hard-coded 10.0.0-rc.19 literal. If package.json or another workspace package drifts, the test still passes as long as this assertion is updated with the source constant, so it does not provide validation evidence for the release-version consistency this PR is changing. Consider deriving the expected value from package/workspace metadata instead of duplicating the target string.

@branarakic branarakic merged commit ff120b3 into main Jun 20, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants