Skip to content

Print initial output before tracking progress #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peb-adr wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −8
Open

Print initial output before tracking progress #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions internal/manage/actions/migrations/migrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,13 @@ func createMigrationCmd(name, description string, withProgressTracking bool) *co
return fmt.Errorf("executing migration command: %w", err)
}

if withProgressTracking && progressInterval != nil && *progressInterval > 0 && (Running(response) || Finalizing(response)) {
fmt.Println("Progress:")
output, err := GetOutput(response, name)
if err != nil {
return fmt.Errorf("formatting output: %w", err)
}
fmt.Print(output)

if withProgressTracking && progressInterval != nil && *progressInterval > 0 && (Running(response) || Finalizing(response)) {
var stopCondition func(*pb.MigrationsResponse) bool
if name == "finalize" {
stopCondition = func(r *pb.MigrationsResponse) bool { return !Running(r) && !Finalizing(r) }
Expand All @@ -157,12 +161,6 @@ func createMigrationCmd(name, description string, withProgressTracking bool) *co
return TrackMigrationProgress(cl, *progressInterval, stopCondition, printCallback)
}

output, err := GetOutput(response, name)
if err != nil {
return fmt.Errorf("formatting output: %w", err)
}

fmt.Print(output)
return nil
}

Expand Down
Loading