Skip to content

fix: support both 'llm' and 'chat_llm' config keys; handle dict core_entities #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: support both 'llm' and 'chat_llm' config keys; handle dict core_entities #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions kag/builder/component/extractor/knowledge_unit_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,10 +584,15 @@ def triple_to_knowledge_unit(triple):
{"name": knowledge_id, "category": "KnowledgeUnit"}
)
core_entities = {}
for item in knowledge_value.get("core_entities", "").split(","):
if not item.strip():
continue
core_entities[item.strip()] = "Others"
raw_core_entities = knowledge_value.get("core_entities", {})
if isinstance(raw_core_entities, dict):
for key, val in raw_core_entities.items():
if key.strip():
core_entities[key.strip()] = val if val else "Others"
else:
for item in str(raw_core_entities).split(","):
if item.strip():
core_entities[item.strip()] = "Others"

for core_entity, ent_type in core_entities.items():
if core_entity == "":
Expand Down
4 changes: 2 additions & 2 deletions knext/command/sub_command/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def create_project(

llm_config_checker = LLMConfigChecker()
vectorize_model_config_checker = VectorizeModelConfigChecker()
llm_config = config.get("chat_llm", {})
llm_config = config.get("llm", config.get("chat_llm", {}))
vectorize_model_config = config.get("vectorizer", {})
try:
llm_config_checker.check(json.dumps(llm_config))
Expand Down Expand Up @@ -260,7 +260,7 @@ def update_project(proj_path):

llm_config_checker = LLMConfigChecker()
vectorize_model_config_checker = VectorizeModelConfigChecker()
llm_config = env.config.get("chat_llm", {})
llm_config = env.config.get("llm", env.config.get("chat_llm", {}))
vectorize_model_config = env.config.get("vectorizer", {})
try:
llm_config_checker.check(json.dumps(llm_config))
Expand Down
Loading