Added a filter to the list of models#443
Open
temaps wants to merge 1 commit into
Open
Conversation
Author
Contributor
|
Looks much better than current filter, which you should know how to turn on and which finds from the beginning of the model only |
zdohnal
requested changes
Jun 25, 2026
zdohnal
left a comment
Member
There was a problem hiding this comment.
In general looks good, but I saw some issues:
- when running the program, I get 2 exceptions:
Traceback (most recent call last):
File "/usr/local/share/system-config-printer/newprinter.py", line 3875, in on_tvNPMakes_cursor_changed
self.fillModelList()
~~~~~~~~~~~~~~~~~~^^
File "/usr/local/share/system-config-printer/newprinter.py", line 3916, in fillModelList
filter_path = self.models_filter.convert_child_iter_to_path(iter)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'TreeModelFilter' object has no attribute 'convert_child_iter_to_path'. Did you mean: 'convert_child_iter_to_iter'?
Caught non-fatal exception. Traceback:
The above happened when I opened the driver dialog during printer adding process.
File "/usr/local/share/system-config-printer/newprinter.py", line 1369, in _handlePrinterInstallationMode
name = model.get(iter, 0)[0]
~~~~~~~~~^^^^^^^^^
File "/usr/lib64/python3.14/site-packages/gi/overrides/Gtk.py", line 1010, in get
values.append(self.get_value(treeiter, col))
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
TypeError: Argument 1 does not allow None as a value
This one I cannot reproduce, but it happened somewhere when I either went back to Manufacturers window, or when I was switching from Brother to HP.
Would you mind looking into them?
Thank you!
Author
Yes, I was wrong... In the final version, I did not replace the method, which I copied from my old project, where I defined this method... I will fix everything now and add a check. |
The list of models is always very long and it is difficult to find the right one. Added a filter field that helps you select only the necessary models from the list.
48a6af5 to
409a2ca
Compare
Author
|
I fixed and did a force push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The list of models is always very long and it is difficult to find the right one. Added a filter field that helps you select only the necessary models from the list.