filter: fix rastertoescpx and rastertopclx legacy paths#691
Open
kimaiden1984-boop wants to merge 1 commit into
Open
filter: fix rastertoescpx and rastertopclx legacy paths#691kimaiden1984-boop wants to merge 1 commit into
kimaiden1984-boop wants to merge 1 commit into
Conversation
Use the selected PPD page size instead of ppd->sizes[1] when computing rastertoescpx margins, and replace rastertopclx EndJob printf handling with a restricted page-count substitution helper. Also add regression tests for both fixes and hook them into make check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two issues in the legacy
cups-filtersfilter path:rastertoescpxno longer assumesppd->sizes[1]exists when computing the printer top margin. It now uses the currently selected/defaultPageSizeviappdPageSize(ppd, NULL).rastertopclxno longer passes*cupsPCL EndJobdirectly toprintf(). It now uses restricted page-count substitution so PPD data is not interpreted as an unrestricted format string.Regression tests
Two regression tests are added and hooked into
make check:test-rastertoescpx-page-sizetest-rastertopclx-format-stringTesting
make -C /data/pre-gsoc/cups-filters -j1 check TESTS='test-rastertopclx-format-string test-rastertoescpx-page-size'