Remove unused vendored JS from the toolbox#21
Open
balloob wants to merge 1 commit into
Open
Conversation
httpdocs/firmware/toolbox/js-yaml.min.js is a stale js-yaml 4.1.0 copy that nothing loads — the toolbox page uses the shared /js/js-yaml.min.js (4.1.1), same as every other page. httpdocs/firmware/toolbox/js/s2/ is an orphaned second esp-web-tools build variant. The toolbox only injects ./js/install-button.js; nothing references the s2/ entry point or its chunks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TEs4tsAWupf2DXFM4faECC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes five dead files under
httpdocs/firmware/toolbox/— no page or script loads them, so the deployed site is unaffected.js-yaml.min.js(stale js-yaml 4.1.0): the toolbox page loads the shared/js/js-yaml.min.js(4.1.1) like every other page (toolbox/index.html:21). Having a second, older copy of the same library next to the page is a footgun — someone editing or auditing it would be looking at code that never runs.js/s2/(4 files —install-button.js,index-7020c696.js,connect-f67814ca.js,esp32s2-da30a731.js): an orphaned second esp-web-tools build. The toolbox's loader only ever injects./js/install-button.js, and thes2/files are referenced by nothing except each other (verified by grepping every path fragment across all HTML/JS inhttpdocs/).Kept, because they ARE loaded via relative paths:
toolbox/jszip.min.js,toolbox/serial.js,toolbox/nrf_web_tools.js, and everything undernrf_web_tools/. (Note:toolbox/nrf_web_tools.jsis an older revision thannrf_web_tools/nrf_web_tools.jsand is missing the multi-part reconnect flow — that's a real divergence, but consolidating it changes behavior, so it belongs in its own PR.)🤖 Generated with Claude Code
https://claude.ai/code/session_01TEs4tsAWupf2DXFM4faECC