ci: run pull-request checks on every base branch - #288
Merged
Conversation
A stacked pull request got zero checks and still reported mergeStateStatus CLEAN. PR #287 targets codex/production-evidence-contract, so the branches: [main] filter on pull_request never matched and no workflow ran. An unverified pull request thus looks the same as a passing one, which is how an untested change reaches main. Remove the base-branch filter from the three pull_request triggers. The push trigger keeps branches: [main]. complex-visual and evidence-freshness keep their paths filters, so the added cost is limited to a stacked pull request that touches those paths. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
abrichr
force-pushed
the
claude/ci-run-on-stacked-prs
branch
from
August 19, 2026 21:44
907b5c0 to
087d7b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
A stacked pull request gets zero checks and still reports
mergeStateStatus: CLEAN.PR #287 targets
codex/production-evidence-contract, notmain. Everypull_requesttrigger in this repository is filtered tobranches: [main], so no workflow matched and nothing ran. Its test numbers came from a local run only.An unverified pull request is indistinguishable from a passing one in the UI and in
gh pr view. That is how an untested change reachesmain.codex/production-evidence-contractcodex/promote-capture-betacodex/push-json-contractopenadapt-flow#372 gets full CI because Flow's
ci.ymlcarries no base filter. That confirms the mechanism.The change
Remove the base-branch filter from the three
pull_requesttriggers. Thepushtrigger keepsbranches: [main].Cost
complex-visualandevidence-freshnesskeep theirpathsfilters, so extra runs happen only when a stacked pull request touches those paths.testruns on every pull request, which is the intent.A matching change is needed in
openadapt-capture.🤖 Generated with Claude Code