[JavaJaxRS] [CXF] Add Support for Jackson3 fixes #23616#23719
Open
fwermelskirchen wants to merge 5 commits intoOpenAPITools:masterfrom
Open
[JavaJaxRS] [CXF] Add Support for Jackson3 fixes #23616#23719fwermelskirchen wants to merge 5 commits intoOpenAPITools:masterfrom
fwermelskirchen wants to merge 5 commits intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 14 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml">
<violation number="1" location="samples/client/petstore/jaxrs-cxf-client-jackson/pom.xml:196">
P1: Upgrading to CXF 4.2.0/Jackson 3.1.2 while keeping the project at Java 8 creates an unsupported JDK baseline mismatch.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
2 issues found across 3 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/pom.mustache:253">
P0: Missing opening '<' in XML element for java.version property in default (useJackson3=false) branch will produce malformed POM</violation>
</file>
<file name="samples/client/petstore/jaxrs-cxf-client-jackson/.openapi-generator/VERSION">
<violation number="1" location="samples/client/petstore/jaxrs-cxf-client-jackson/.openapi-generator/VERSION:1">
P3: Generated sample metadata was downgraded to an older generator snapshot, making the sample inconsistent with the repo's current version.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -1 +1 @@ | |||
| 7.23.0-SNAPSHOT | |||
| 7.22.0-SNAPSHOT | |||
Contributor
There was a problem hiding this comment.
P3: Generated sample metadata was downgraded to an older generator snapshot, making the sample inconsistent with the repo's current version.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/jaxrs-cxf-client-jackson/.openapi-generator/VERSION, line 1:
<comment>Generated sample metadata was downgraded to an older generator snapshot, making the sample inconsistent with the repo's current version.</comment>
<file context>
@@ -1 +1 @@
-7.23.0-SNAPSHOT
+7.22.0-SNAPSHOT
</file context>
Suggested change
| 7.22.0-SNAPSHOT | |
| +7.23.0-SNAPSHOT |
Member
|
thanks for the PR. please follow step 3 to update the samples |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds Jackson 3 support to the Java JAX-RS CXF client generator via a new
useJackson3option. When enabled, it usestools.jacksonpackages, the Jakarta RS provider, CXF 4.2.0, and Java 11; Jackson 2 with Java 8 remains the default.New Features
useJackson3; setsjacksonPackagetotools.jackson(v3) orcom.fasterxml.jackson(v2).{{jacksonPackage}}; selects jackson-jaxrs 3.1.2 + CXF 4.2.0 for v3, else 2.17.1 + CXF 3.5.9....jakarta.rs...; v2 uses...jakarta.rs...only whenuseJakartaEeis true, otherwisecom.fasterxml.jackson.jaxrs.jackson-datatype-jsr310whenuseJackson3.Migration
additionalPropertiesuseJackson3: "true"(anduseJakartaEe: "true").Written for commit d4876fc. Summary will update on new commits.