Skip to content

fix: [SDK-4858] restore UPM sample and validate Asset Store package contents#887

Merged
fadi-george merged 4 commits into
mainfrom
fadi/sdk-4858
Jul 13, 2026
Merged

fix: [SDK-4858] restore UPM sample and validate Asset Store package contents#887
fadi-george merged 4 commits into
mainfrom
fadi/sdk-4858

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Repair the canonical UPM sample and align Asset Store inventory, exports, CI validation, and documentation with the shipped layout.

Details

Motivation

The Full Usage sample was missing its assembly definition, metadata, and font, while stale scene bindings prevented buttons from resolving. Separately, Asset Store inventory and export rules had drifted, causing generated dependency files to be treated as legacy and making package contents unreliable.

Scope

  • Restores and validates the minimal UPM Full Usage sample.
  • Centralizes Asset Store inventory and export exclusions.
  • Adds pre-export and CI distribution validation.
  • Makes bootstrap documentation exportable and updates stale sample links.
  • Ignores Android libraries generated by External Dependency Manager.
  • Does not change OneSignal public runtime APIs.

Testing

Unit testing

No unit-test framework exists for this distribution tooling. A repository validator now checks inventory parity, sample GUIDs, assembly references, scene bindings, and package registration in CI.

Manual testing

  • Imported and compiled the Full Usage sample with Unity 2022.3.62f3 and Unity 6000.4.11f1.
  • Compiled the demo with both supported editor versions (Unity 2022 compatibility overlaid with the pending compatibility branch).
  • Confirmed inventory generation is idempotent.
  • Exported and inspected the .unitypackage; 39 bootstrap assets were present with Example, Attribution, packager tooling, demo assets, generated dependency XMLs, and .env excluded.
  • Ran csharpier check ., git diff --check, and .github/scripts/validate-unity-distribution.py.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Distribution and editor tooling were tested in Unity editors; no physical-device behavior changed.

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Made with Cursor

@fadi-george fadi-george requested a review from a team as a code owner July 10, 2026 18:05
fadi-george and others added 4 commits July 13, 2026 11:36
Repair the UPM sample and make Asset Store inventory, export validation, and documentation agree on shipped content.

Co-authored-by: Cursor <cursoragent@cursor.com>
@fadi-george fadi-george changed the title fix: [SDK-4858] align Unity distribution layout fix: [SDK-4858] restore UPM sample and validate Asset Store package contents Jul 13, 2026
@fadi-george fadi-george merged commit 97b09d5 into main Jul 13, 2026
4 checks passed
@fadi-george fadi-george deleted the fadi/sdk-4858 branch July 13, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants