Skip to content

feat(thruster): support bottom propeller for single direction mode #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tibnor wants to merge 3 commits into
base: develop
Choose a base branch
from
+20 −3
Open

feat(thruster): support bottom propeller for single direction mode #1010

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82ecf8
feat(thruster): support bottom propeller for single direction thrusters
claude Jun 25, 2026
c3250e8
test(thruster): add visual baseline for single direction propellers
claude Jun 25, 2026
3fa3aa4
fix(thruster): avoid clipping single direction bottom propeller
claude Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/openbridge-webcomponents/src/navigation-instruments/thruster/thruster.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,18 @@ export const SingleDirection: Story = {
},
};

export const SingleDirectionWithPropellers: Story = {
args: {
singleDirection: true,
thrust: 50,
setpoint: 30,
state: InstrumentState.active,
priority: Priority.enhanced,
topPropeller: PropellerType.single,
bottomPropeller: PropellerType.cap,
},
};
Comment thread
tibnor marked this conversation as resolved.

export const SingleDirectionSingleSidedWithAdvice: Story = {
args: {
singleDirection: true,
Expand Down
17 changes: 14 additions & 3 deletions packages/openbridge-webcomponents/src/navigation-instruments/thruster/thruster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,12 +756,23 @@ export function thruster(
let viewBox = '-80 -160 160 320';
let y = -160;
if (options.singleDirection) {
viewBox = '-80 -300 160 320';
y = -320;
if (options.bottomPropeller !== PropellerType.none) {
// Make room below the zero line for the bottom propeller while keeping
// the doubled-height bar and the top propeller in view.
viewBox = '-80 -268 160 320';
y = -288;
} else {
viewBox = '-80 -300 160 320';
y = -320;
}
}
const top = topPropeller(height, tc.arrowColor, options.topPropeller);
// For single direction thrusters the bar only extends upwards and its base
// sits on the zero line, so the bottom propeller must be attached there
// (like the half size variant) instead of at the bottom of a (missing)
// downward bar.
const bottom = bottomPropeller(
options.singleDirectionHalfSize ? 0.5 : height,
options.singleDirectionHalfSize || options.singleDirection ? 0.5 : height,
options.bottomPropeller
);
return svg`
Expand Down
Loading