Skip to content

cmake: set BUILD_ARCH with CMAKE_HOST_SYSTEM_PROCESSOR #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nilason wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −46
Open

cmake: set BUILD_ARCH with CMAKE_HOST_SYSTEM_PROCESSOR #7369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@ option(WITH_FHS "Install with FHS" OFF)
include(check_target)
include(CheckDependentLibraries)

include(get_host_arch)
get_host_arch(BUILD_ARCH)
set(BUILD_ARCH ${CMAKE_HOST_SYSTEM_PROCESSOR})
Copy link
Copy Markdown
Member

@HuidaeCho HuidaeCho May 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. Can we apply lowercase on Windows? Currently,

  • Linux: x86_64
  • macOS: x86_64, arm64
  • Windows: AMD64 (should we unify it to x86_64?)

Copy link
Copy Markdown
Contributor Author

@nilason nilason May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we apply lowercase on Windows? ... (should we unify it to x86_64?)

I think it should be as straightforward as possible, that is, leave it as is.

Copy link
Copy Markdown
Contributor Author

@nilason nilason May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is: what do we want to show with build_platform? What relevant information should be output from a CMake build? And when/where would that be helpful? E.g., if a package is cross compiled, it may be of interest what was the host platform.


# Setup GRASS install directories
include(GRASSInstallDirs)
Expand Down
44 changes: 0 additions & 44 deletions cmake/modules/get_host_arch.cmake
View file
Open in desktop

This file was deleted.

Loading