Skip to content

lib/vector: improve numerical stability for point-in-polygon calculations #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metzm merged 5 commits into from
May 8, 2026
+226 −126
Merged

lib/vector: improve numerical stability for point-in-polygon calculations #7333

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e86bda5
improve numerical stability for point-in-polygon
metzm Apr 18, 2026
c61cd8e
improve intersection calculation
metzm Apr 19, 2026
160b88a
Update lib/vector/Vlib/poly.c
metzm Apr 21, 2026
e8a1e09
add review suggestions
metzm Apr 21, 2026
f0adfe4
Update lib/vector/Vlib/poly.c
metzm May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/grass/defs/vector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,9 @@ int Vect_tin_get_z(struct Map_info *, double, double, double *, double *,

/* int Vect_point_in_islands (struct Map_info *, int, double, double); */
int Vect_find_poly_centroid(const struct line_pnts *, double *, double *);
int Vect_find_poly_centroid_cog(const struct line_pnts *,
const struct line_pnts **, int, double *,
double *);
int Vect__intersect_line_with_poly(const struct line_pnts *, double,
struct line_pnts *);
int Vect_get_point_in_area(struct Map_info *, int, double *, double *);
Expand Down
4 changes: 3 additions & 1 deletion lib/vector/Vlib/find.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,9 @@ int Vect_find_area(struct Map_info *Map, double x, double y)
G_debug(3, " area = %d Vect_point_in_area_outer_ring() = %d", area,
ret);

if (ret >= 1) {
/* the point must be really inside (ret = 1), not on the boundary (ret =
* 2) */
if (ret == 1) {
/* check if in islands */
Area = Plus->Area[area];
for (j = 0; j < Area->n_isles; j++) {
Expand Down
Loading
Loading