-
-
Notifications
You must be signed in to change notification settings - Fork 427
lib/python/pygrass: fix Python 3.14 pickling error in grid tests #7257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SyedAhad01
wants to merge
43
commits into
OSGeo:main
Choose a base branch
from
SyedAhad01:fix-python314-pickling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 40 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
19ec6f4
pygrass: fix Python 3.14 pickling error in grid tests
SyedAhad01 1aca37a
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 502ddda
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 16c1a0d
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 6e169e2
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 8f2f7b1
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 91f092c
fix: convert line endings to LF
SyedAhad01 0f6a319
fix: final formatting
SyedAhad01 3246d81
final fix: formatting applied
SyedAhad01 4d8e071
fix: use set for exitcode check
SyedAhad01 ca5876e
final fix: correct subprocess handling
SyedAhad01 ec23d60
fix: propagate GridModule errors via sys.exit in subprocess
SyedAhad01 9670574
fix: correct indentation and cleanup in test_cleans
SyedAhad01 a813fa7
fix: correct check condition in test_cleans for spawn vs fork
SyedAhad01 d1616f1
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 e65d6b4
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 f3360f6
Update python/grass/pygrass/modules/tests/grass_pygrass_grid_test.py
SyedAhad01 4d91b1b
fix: remove xfail_mp_spawn decorators as pickling is now fixed
SyedAhad01 9f5e665
fix: correct new_mset tuple to string in get_works
SyedAhad01 e05641f
fix: pass environment variables explicitly to subprocess workers for …
SyedAhad01 c80c67e
pygrass: fix copy_groups to use passed env instead of overwriting it
SyedAhad01 d6048dc
pygrass: fix copy_groups to use passed env instead of overwriting it
SyedAhad01 7906a4b
Update python/grass/pygrass/modules/grid/grid.py
SyedAhad01 ffbc286
trigger CI: verify ruff fixes
SyedAhad01 c9cbdbf
Update python/grass/pygrass/modules/grid/grid.py
SyedAhad01 96fb15f
pygrass: fix missing ctx assignment in GridModule.run
SyedAhad01 b3ad7f7
pygrass: add self.env and pass it consistently to workers
SyedAhad01 829c5db
fix: correct line endings
SyedAhad01 984519d
fix: use shell=False in Popen for security (Bandit B603)
SyedAhad01 3a29d20
fix: correct indentation and f-string in grid.py
SyedAhad01 6cb8b92
fix: check return code in cmd_exe to surface GRASS errors
SyedAhad01 b21a564
fix: Python 3.14 pickling compatibility in GridModule
SyedAhad01 834728b
fix: remove forced spawn context, keep pickling fixes for Python 3.14
SyedAhad01 66dcb3e
debug: print worker exitcode in test
SyedAhad01 05cf371
debug: print full traceback in subprocess
SyedAhad01 7c4d5c7
style: apply ruff and format fixes
SyedAhad01 1127d69
ci: temporarily add Python 3.14 to pytest workflow to verify fix
SyedAhad01 995cba0
fix: address ruff linting issues in GridModule and tests
SyedAhad01 5f641c3
ci: add Python 3.14 to pytest workflow
SyedAhad01 12c21af
ci: revert fail-fast to true
SyedAhad01 13ba465
ci: remove Python 3.13 from pytest workflow, keep 3.10 and 3.14
SyedAhad01 6b6ee41
Merge branch 'main' into fix-python314-pickling
SyedAhad01 124643f
Merge branch 'main' into fix-python314-pickling
echoix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,6 +25,7 @@ jobs: | |
| python-version: | ||
| - "3.10" | ||
| - "3.13" | ||
| - "3.14" | ||
| fail-fast: true | ||
|
|
||
| runs-on: ${{ matrix.os }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.