processEclipseFormat: honour the numerical aquifer mode - #1059
Draft
hnil wants to merge 1 commit into
Draft
Conversation
Three places let the numerical aquifers of a deck reshape the grid: cells are kept alive so that a zero-thickness aquifer cell survives processing, the AQUCON connections are turned into non-neighbour connections (and appended to the EclipseState), and the aquifer cell volumes overwrite the geometric ones. All three are conditional on the deck having numerical aquifers. Make them conditional on those aquifers actually being represented by grid cells, which EclipseState now states directly. In AuxiliaryCells mode the grid comes out exactly as it would without the AQUNUM records. Not generating the non-neighbour connections is also what makes such a deck usable with edge-conformal processing, which rejects them outright a few lines further up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
hnil
added
the
manual:enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes the numerical aquifer mode through to grid processing, so that in
auxmode theAQUNUM cells and their AQUCON connections are not folded into the grid as NNCs.
Default is unchanged.
Needs OPM/opm-common#5286 for the mode itself. Draft — CI not yet green.
🤖 Generated with Claude Code