Populate Region Variable Mapping From Summary Config - #5279
Draft
bska wants to merge 1 commit into
Draft
Conversation
bska
added
the
manual:irrelevant
Member
Author
|
I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #5278. I will keep the PR in a draft state until such time as it is ready for review. |
This was referenced Aug 6, 2026
bska
force-pushed
the
reg-var-register-connopt
branch
13 times, most recently
from
August 14, 2026 09:16
f79428d to
64029bc
Compare
bska
force-pushed
the
reg-var-register-connopt
branch
5 times, most recently
from
August 17, 2026 10:10
45d1850 to
312c517
Compare
Member
Author
|
jenkins build this please |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new SummaryConfig-driven helper to register internal region-variable dependencies in a data::RegionVariableMapping, initially focused on oil-efficiency (*OEW*) summary vectors so required per-region cumulative production can be tracked without exposing extra COPT vectors in user-visible summary output.
Changes:
- Introduces
populateRegVarMapping()API for deriving mapping registrations fromSummaryConfig. - Implements initial
*OEW*detection and registration ofConnOPTplus required region sets (e.g.,FIPNUMor configured region set for ROEW_*). - Wires the new compilation unit and public header into the build via CMake file lists.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| opm/input/eclipse/EclipseState/SummaryConfig/RegionVariableSupport.hpp | Declares populateRegVarMapping() for populating a RegionVariableMapping from SummaryConfig. |
| opm/input/eclipse/EclipseState/SummaryConfig/RegionVariableSupport.cpp | Implements initial mapping population for *OEW* vectors by registering ConnOPT and needed region sets. |
| CMakeLists_files.cmake | Adds the new source and public header to the build/install lists. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+31
to
+34
| namespace Opm { | ||
| void populateRegVarMapping(const SummaryConfig& sumcfg, | ||
| data::RegionVariableMapping& regVarMap); | ||
| } |
Comment on lines
+30
to
+34
| // FOEW, ROEW, ROEW_<REG> | ||
| const auto oew_kws = sumcfg.keywords(R"(*OEW*)"); | ||
|
|
||
| if (oew_kws.empty()) { | ||
| // No *OEW* vectors requested. Nothing to do. |
bska
force-pushed
the
reg-var-register-connopt
branch
4 times, most recently
from
August 20, 2026 07:12
a18fca9 to
419e98e
Compare
bska
force-pushed
the
reg-var-register-connopt
branch
from
August 21, 2026 09:10
419e98e to
0022324
Compare
This commit adds a special purpose helper function,
populateRegVarMapping()
that, based on the run's configured summary vectors, populates an
object of type data::RegionVariableMapping.
In this initial implementation, we define a variable named
ConnOPT
if any of the *OEW* summary vectors are configured in the run's
SUMMARY section. Those OEW vectors require tracking the per-region
cumulative oil production from wells and it's easier to have a
dedicated variable for this than to introduce extra "COPT" summary
vectors that are visible to the user through the result set's
summary files (e.g., .SMSPEC and .UNSMRY).
bska
force-pushed
the
reg-var-register-connopt
branch
from
August 21, 2026 16:14
0022324 to
86f1597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a special purpose helper function,
that, based on the run's configured summary vectors, populates an object of type
data::RegionVariableMapping(#5274).In this initial implementation, we define a variable named
ConnOPTif any of the
*OEW*summary vectors are configured in the run'sSUMMARYsection. Those OEW vectors require tracking the per-region cumulative oil production from wells and it's easier to have a dedicated variable for this than to introduce extraCOPTsummary vectors that are visible to the user through the result set's summary files (e.g.,.SMSPECand.UNSMRY).