Add option for longer dynamic spinups#1914
Open
pat-schmitt wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I introduce a new methodology that allows for longer spinup periods during dynamic spinup, particularly when creating the preprocessed directories. When dynamic spinup was initially developed, historical data was only available from 1979, so the spinup in the prepro levels was limited to that year. However, historical data is now available from 1901, and recent studies have shown that some glaciers require a longer spinup period.
Main changes:
spinup_periods_to_tryintasks.run_dynamic_spinup: accepts a list of additional spinup periods, which are tried in order if both the initially defined spinup period (spinup_period_initial) and the minimum spinup period (min_spinup_period) fail. This means we first try the old default workflow, and only if this fails we try the additional spinup periods.--dynamic-spinup-periods-to-tryinprepro_levels.py, defaulting to[30, 40, 50, 60, 70, 80, 90, 100]. To disable this new behaviour, set--dynamic-spinup-periods-to-try none._historical_spinupin the prepro levels still starts from 1979, which is achieved viafixed_geometry_spinup_yr. Iffixed_geometry_spinup_yr(e.g. 1979) is later thanFlowlineModel.yr(e.g. 1950), the model runs untilfixed_geometry_spinup_yrbefore storing any output. This works for now, but should eventually be made more explicit. For example, by adding a new kwarg such asstart_yr_to_store_model_output.Related to #1837: but no real optimization to find the best spinup time, we just look for any working spinup time, and try to have it as short as possible, up to a maximum of 100 years spinup
whats-new.rst