Skip to content

[MIG] web_widget_char_size: Migration to 18.0 - #3421

Merged
OCA-git-bot merged 6 commits into
OCA:18.0from
PyTech-SRL:18.0-mig-web_widget_char_size
Jul 21, 2026
Merged

[MIG] web_widget_char_size: Migration to 18.0#3421
OCA-git-bot merged 6 commits into
OCA:18.0from
PyTech-SRL:18.0-mig-web_widget_char_size

Conversation

@SirPyTech

@SirPyTech SirPyTech commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Migration from 16.0 (https://github.com/OCA/web/tree/d27d8cc50de0c117b84dbeb4aa0da1575938bb41/web_widget_char_size).

The migration includes a fix to the contributors file name, backported to affected versions with #3422 and #3423.

@SirPyTech
SirPyTech marked this pull request as ready for review January 29, 2026 11:51
@SirPyTech
SirPyTech force-pushed the 18.0-mig-web_widget_char_size branch from c996709 to 131de3d Compare January 29, 2026 11:57
quirino95
quirino95 approved these changes Feb 6, 2026
View reviewed changes

@quirino95 quirino95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review: LGTM!

Comment thread web_widget_char_size/i18n/it.po
Comment thread web_widget_char_size/i18n/web_widget_char_size.pot
StefanRijnhart
StefanRijnhart reviewed Apr 7, 2026
View reviewed changes
Comment thread web_widget_char_size/static/src/js/char_widget.esm.js Outdated
anusriNPS
anusriNPS approved these changes Apr 16, 2026
View reviewed changes

@anusriNPS anusriNPS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional Review: LGTM

Comment thread web_widget_char_size/static/src/js/char_widget.esm.js
@OCA-git-bot

OCA-git-bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart

StefanRijnhart commented Apr 16, 2026

Copy link
Copy Markdown
Member

Just updating my review status here as per my earlier comment about overriding the getter on a higher level.

@SirPyTech
SirPyTech force-pushed the 18.0-mig-web_widget_char_size branch from 131de3d to d72d1b2 Compare May 20, 2026 11:02
@OCA-git-bot OCA-git-bot added series:18.0 mod:web_widget_char_size Module web_widget_char_size labels May 20, 2026
@SirPyTech
SirPyTech requested a review from StefanRijnhart May 20, 2026 11:04
StefanRijnhart
StefanRijnhart approved these changes May 20, 2026
View reviewed changes

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart

StefanRijnhart commented May 20, 2026

Copy link
Copy Markdown
Member

/ocabot migration web_widget_char_size

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone May 20, 2026
@StefanRijnhart

StefanRijnhart commented May 20, 2026

Copy link
Copy Markdown
Member

Three approvals and other comments also resolved, so

/ocabot merge nobump

@OCA-git-bot OCA-git-bot mentioned this pull request May 20, 2026
Open
49 tasks
@OCA-git-bot

OCA-git-bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3421-by-StefanRijnhart-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot

OCA-git-bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3421-by-StefanRijnhart-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sergiocorato

sergiocorato commented Jul 21, 2026

Copy link
Copy Markdown

@StefanRijnhart could you check the failed merge?

@SirPyTech
SirPyTech force-pushed the 18.0-mig-web_widget_char_size branch from d72d1b2 to bd2ef23 Compare July 21, 2026 07:12
@StefanRijnhart

StefanRijnhart commented Jul 21, 2026

Copy link
Copy Markdown
Member

@SirPyTech thanks for the rebase!

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-3421-by-StefanRijnhart-bump-nobump, awaiting test results.

@SirPyTech

SirPyTech commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for merging! This PR was ~300 commits behind, so a rebase was due.

And also grazie a @sergiocorato for reminding me of this one!

@OCA-git-bot
OCA-git-bot merged commit 65bd94a into OCA:18.0 Jul 21, 2026
9 checks passed
@OCA-git-bot

OCA-git-bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at aab90f5. Thanks a lot for contributing to OCA. ❤️

@HekkiMelody
HekkiMelody deleted the 18.0-mig-web_widget_char_size branch August 25, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes
+3 more reviewers
@sergiocorato sergiocorato sergiocorato left review comments
@anusriNPS anusriNPS anusriNPS approved these changes
@quirino95 quirino95 quirino95 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:web_widget_char_size Module web_widget_char_size ready to merge series:18.0

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

9 participants

@SirPyTech @OCA-git-bot @StefanRijnhart @sergiocorato @quirino95 @anusriNPS @SimoRubi @BankyKmitl @mymage