[MIG] pos_barcode_rule_priced_with_change_rate: Migration to 19.0#1553
[MIG] pos_barcode_rule_priced_with_change_rate: Migration to 19.0#1553niravrathod wants to merge 10 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:pos_barcode_rule_priced_with_change_rate
niravrathod
force-pushed
the
19.0-mig-pos_barcode_rule_priced_with_change_rate
branch
from
11021ff to
cffad9d
Compare
|
Hi, @stferraro, @pedrobaeza, @legalsylvain, @miquelalzanillas, please check this pr and approve! |
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
Could you respect history ? Cherry picking commits ?
Thanks !
Currently translated at 100.0% (6 of 6 strings) Translation: pos-18.0/pos-18.0-pos_barcode_rule_priced_with_change_rate Translate-URL: https://translation.odoo-community.org/projects/pos-18-0/pos-18-0-pos_barcode_rule_priced_with_change_rate/it/
niravrathod
force-pushed
the
19.0-mig-pos_barcode_rule_priced_with_change_rate
branch
from
cffad9d to
f459dfe
Compare
Hi @legalsylvain, I've updated the PR to preserve the commit history. Please review when you have a moment! |
stferraro
left a comment
stferraro
left a comment
There was a problem hiding this comment.
Error opening the Point of Sale
niravrathod
force-pushed
the
19.0-mig-pos_barcode_rule_priced_with_change_rate
branch
from
f459dfe to
f73a0a6
Compare
Hi @stferraro, could you please re-check, I have fixed those tour issues? Thanks. |
Thanks for the review and approval, @stferraro! @legalsylvain, just a friendly ping. I updated the commit history yesterday as requested. Let me know if it looks good to you now! |
|
Hi @mymage, @trisdoan, @Camille0907, and @legalsylvain. The commit history has been updated, and all checks are passing. Could you please review and approve when you have a moment? Thanks! |
|
Hi @legalsylvain, just a friendly ping on this PR! The commit history was updated a few days ago to address your feedback. Could you please take a look when you have a moment? Thanks! |
dnplkndll
left a comment
dnplkndll
left a comment
There was a problem hiding this comment.
LGTM
pre existing but you might drop this or move to test folder, just a console.log()
pos_barcode_rule_priced_with_change_rate/static/src/tours/pos_barcode_tour.esm.js
Done! Dropped the leftover console.log() from the tour. Thanks for the catch and the approval! |
|
@legalsylvain Any update on this? |
8 participants
No description provided.