[16.0] [IMP] fieldservice_isp_account: show bill_to field only when installed#1550
Open
eLBati wants to merge 1 commit into
Open
[16.0] [IMP] fieldservice_isp_account: show bill_to field only when installed#1550eLBati wants to merge 1 commit into
eLBati wants to merge 1 commit into
Conversation
The bill_to field is defined in fieldservice_account_analytic but its value is only consumed by fieldservice_isp_account (account_prepare_invoice). With only fieldservice_account_analytic installed, the user was shown a required "Bill Location / Bill Contact" radio that had no effect. Move the "Accounting" page and the bill_to widget from the fieldservice_account_analytic form view into the fieldservice_isp_account form view, so the field is only displayed when the module that actually uses it is installed. The field definition stays on the model in fieldservice_account_analytic, so the database column is preserved and no migration is required.
Contributor
|
Hi @bodedra, @osimallen, @brian10048, |
OCA-git-bot
added
series:16.0
mod:fieldservice_isp_account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bill_to field is defined in fieldservice_account_analytic but its
value is only consumed by fieldservice_isp_account (account_prepare_invoice).
With only fieldservice_account_analytic installed, the user was shown a
required "Bill Location / Bill Contact" radio that had no effect.
Move the "Accounting" page and the bill_to widget from the
fieldservice_account_analytic form view into the fieldservice_isp_account
form view, so the field is only displayed when the module that actually
uses it is installed.
The field definition stays on the model in fieldservice_account_analytic,
so the database column is preserved and no migration is required.