[16.0] [FIX] fieldservice_sale: fall back to partner's primary service location#1549
Open
eLBati wants to merge 1 commit into
Open
[16.0] [FIX] fieldservice_sale: fall back to partner's primary service location#1549eLBati wants to merge 1 commit into
eLBati wants to merge 1 commit into
Conversation
When autofilling a Sale Order's Service Location, the location was only resolved by matching an fsm.location whose related partner_id is the SO customer, its shipping partner or its commercial partner. A customer that is an ordinary contact (not itself a location) was left without a location, even when its res.partner.service_location_id explicitly pointed at one. Add service_location_id as a last-resort fallback in _compute_fsm_location_id: the existing partner -> location matching still takes precedence, and the customer's primary service location is used only when no other match is found. service_location_id is added to the field's depends so the SO location recomputes when it changes.
Contributor
|
Hi @wolfhall, @max3903, @brian10048, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When autofilling a Sale Order's Service Location, the location was only
resolved by matching an fsm.location whose related partner_id is the SO
customer, its shipping partner or its commercial partner. A customer that
is an ordinary contact (not itself a location) was left without a location,
even when its res.partner.service_location_id explicitly pointed at one.
Add service_location_id as a last-resort fallback in
_compute_fsm_location_id: the existing partner -> location matching still
takes precedence, and the customer's primary service location is used only
when no other match is found. service_location_id is added to the field's
depends so the SO location recomputes when it changes.