You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The version 20.26.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of electron-builder.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes20.26.0
Major bug fixed for AppImage. To ensure that your application windows have correct task bar icon, StartupWMClass should be set for some Linux distros. For example, app icon is correctly displayed on Ubuntu 16, but not icon on Ubuntu 18.
Now, since electron-builder 20.26.0, StartupWMClass is correctly set.
What you should do: just upgrade electron-builder to 20.26.0 and your app icon will be correctly displayed on Ubuntu 18.
Please note — Electron uses product name as WM_CLASS but non-ASCII symbols doesn't work. It means that if your product name is ß app, icon will be not set for app windows because of ß symbol. Workaround: do not set productName in the root of package.json, move it to build (to electron-builder config). Or always working solution.
Since this release electron-updater compatibility is set to >=2.15 it means that latest-mac.json is no longer generated and no sha256 checksums for Windows artifacts (sha512 is used instead for 2 years already).
Bug Fixes
appx: Apps are not allowed to have a Version with a revision number other than zero specified in the app manifest (86cd1d9), closes #2979
Weird ref_0 lines being written in latest-mac.yml (72c858c), closes #2993
electron-updater: unify "update-downloaded" event on macOS (86d64c2)
Features
electron-updater: download update on macOS in the same way as for other OS (f966f1a), closes #3168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 20.26.0 of electron-builder was just published.
The version 20.26.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of electron-builder.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Release Notes
20.26.0Major bug fixed for AppImage. To ensure that your application windows have correct task bar icon,
StartupWMClassshould be set for some Linux distros. For example, app icon is correctly displayed on Ubuntu 16, but not icon on Ubuntu 18.Now, since electron-builder
20.26.0,StartupWMClassis correctly set.What you should do: just upgrade electron-builder to
20.26.0and your app icon will be correctly displayed on Ubuntu 18.Please note — Electron uses product name as
WM_CLASSbut non-ASCII symbols doesn't work. It means that if your product name isß app, icon will be not set for app windows because ofßsymbol. Workaround: do not setproductNamein the root ofpackage.json, move it tobuild(to electron-builder config). Or always working solution.Features
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴