Skip to content

spek: fix build failure due to ffmpeg=8 - #459915

Merged
bjornfor merged 1 commit into
NixOS:staging-nextfrom
booxter:spek
Nov 9, 2025
Merged

spek: fix build failure due to ffmpeg=8#459915
bjornfor merged 1 commit into
NixOS:staging-nextfrom
booxter:spek

Conversation

@booxter

@booxter booxter commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@booxter booxter added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 9, 2025
@booxter
booxter marked this pull request as ready for review November 9, 2025 00:45
@nixpkgs-ci
nixpkgs-ci Bot requested a review from bjornfor November 9, 2025 00:46
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 9, 2025
@booxter

booxter commented Nov 9, 2025

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 459915
Commit: 9e33d07cfadde9b64466a54b27e31db4bc4f7ff1

x86_64-linux

✅ 1 package built:
  • spek

aarch64-linux

✅ 1 package built:
  • spek

@booxter

booxter commented Nov 9, 2025

Copy link
Copy Markdown
Contributor Author

Darwin checks are blocked due to #459646

@bjornfor

bjornfor commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

Direct link to upstream PR: alexkay/spek#338

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 9, 2025
@bjornfor
bjornfor added this pull request to the merge queue Nov 9, 2025
Merged via the queue into NixOS:staging-next with commit ed6225b Nov 9, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@booxter @bjornfor