Don't validate diff-index control nodes as regular Oak index definitions - #50
Open
paulochang wants to merge 2 commits into
Open
Don't validate diff-index control nodes as regular Oak index definitions#50paulochang wants to merge 2 commits into
paulochang wants to merge 2 commits into
Conversation
/oak:index/diff.index and /oak:index/diff.index.optimizer are control nodes for Oak's simplified index management (diff indexes, OAK-12010), not index definitions themselves. The validator previously required every oak:QueryIndexDefinition node to have type=lucene, compatVersion=2 and a <name>-<N>-custom-<M> node name, which these correctly-formed control nodes never satisfy, producing 3 false positives. Exempt exactly these two paths from those checks, while still requiring type=disabled on them, since Oak silently disables the whole merge mechanism if that value is anything else. Fixes Netcentric#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/oak:index/diff.index and /oak:index/diff.index.optimizer are control nodes for Oak's simplified index management (diff indexes, OAK-12010), not index definitions themselves, so the type=lucene, compatVersion=2 and naming-pattern checks don't apply to them.
Exempt exactly these two paths, but still require type=disabled on them, since Oak silently disables the whole merge mechanism if that value is anything else.
Add unit tests
This closes #49