miscfs/fullfs: add disk-full simulation layerfs based on miscfs/nullfs#79
miscfs/fullfs: add disk-full simulation layerfs based on miscfs/nullfs#79dalpra-hcd wants to merge 2 commits intoNetBSD:trunkfrom
Conversation
There was a problem hiding this comment.
would probably use strtoi()
There was a problem hiding this comment.
all the 1's should be EXIT_FAILURE.
There was a problem hiding this comment.
we have estrdup() in libutil... and other e-functions.
There was a problem hiding this comment.
you can put the index declaration in the loop.
There was a problem hiding this comment.
you don't want to allow it to be 0 again?
There was a problem hiding this comment.
I thought it didn't make sense setting mode to failing after 0 write counts, you might as well set to fail straight. So requiring mode count + positive doom seems logical.
|
Hello @zoulasc, Thanks for your review, will work on those and let you know once it is ready again! |
dalpra-hcd
force-pushed
the
implement-fullfs
branch
from
8a0061c to
1e53a14
Compare
dalpra-hcd
force-pushed
the
implement-fullfs
branch
from
1e53a14 to
7b3d353
Compare
|
Didn't have time to run the atf test yet, will confirm everything is still passing and re-request the review. |
2 participants
No description provided.