Skip to content

Bugfix/cstackex 155: Fix VM provisioning after a pool comes out of maintenance mode #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piyush5netapp merged 5 commits into from
May 18, 2026
Merged

Bugfix/cstackex 155: Fix VM provisioning after a pool comes out of maintenance mode #56

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b56255
bugfix/CSTACKEX-155: Fix cancel maintain for vm provisioning
May 12, 2026
6e94d34
bugfix/CSTACKEX-155: Fix cancel maintain for vm provisioning update c…
May 12, 2026
9404164
Merge branch 'main' of https://github.com/NetApp/cloudstack into bugf…
May 15, 2026
c894d9a
bugfix/CSTACKEX-155: Fix cancel maintain for vm provisioning 1
May 15, 2026
15059ee
bugfix/CSTACKEX-155: Fix cancel maintain for vm provisioning 2
May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/com/cloud/storage/StorageManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3109,7 +3109,7 @@ public void updateStoragePoolHostVOAndBytes(StoragePool pool, long hostId, Modif
}

StoragePoolVO poolVO = _storagePoolDao.findById(pool.getId());
if (!Storage.StoragePoolType.StorPool.equals(poolVO.getPoolType())) {
if (!Storage.StoragePoolType.StorPool.equals(poolVO.getPoolType()) && !poolVO.getStorageProviderName().equals(DataStoreProvider.ONTAP_PLUGIN_NAME) ) {
Copy link
Copy Markdown

@rajiv-jain-netapp rajiv-jain-netapp May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommneded practice to keep the constant first then compare with variable example

DataStoreProvider.ONTAP_PLUGIN_NAME.equals(poolVO.getStorageProviderName())

Copy link
Copy Markdown
Author

@piyush5netapp piyush5netapp May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajiv-jain-netapp Taken care.

poolVO.setUsedBytes(mspAnswer.getPoolInfo().getCapacityBytes() - mspAnswer.getPoolInfo().getAvailableBytes());
poolVO.setCapacityBytes(mspAnswer.getPoolInfo().getCapacityBytes());
}
Expand Down
Loading