Skip to content

Add support for Fixed Resolution/Quantization MGDS changes. #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maedtb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for Fixed Resolution/Quantization MGDS changes. #1337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a3ec0
Add support for Fixed Resolution/Quantization MGDS changes.
maedtb Feb 21, 2026
4ce059d
Rename `aspect_bucketing_quantization` to `resolution_quantization`.
maedtb Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/dataLoader/StableDiffusionFineTuneVaeDataLoader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,10 @@ def __mask_augmentation_modules(self, config: TrainConfig) -> list:
def __aspect_bucketing_in(self, config: TrainConfig):
calc_aspect = CalcAspect(image_in_name='image', resolution_out_name='original_resolution')

quantization = 8

aspect_bucketing = AspectBucketing(
quantization=8,
quantization=quantization,
resolution_in_name='original_resolution',
target_resolution_in_name='settings.target_resolution',
enable_target_resolutions_override_in_name='concept.image.enable_resolution_override',
Expand All @@ -122,7 +124,8 @@ def __aspect_bucketing_in(self, config: TrainConfig):
target_resolutions_override_in_name='concept.image.resolution_override',
scale_resolution_out_name='scale_resolution',
crop_resolution_out_name='crop_resolution',
possible_resolutions_out_name='possible_resolutions'
possible_resolutions_out_name='possible_resolutions',
quantization=quantization,
)

modules = [calc_aspect]
Expand Down
7 changes: 4 additions & 3 deletions modules/dataLoader/mixin/DataLoaderText2ImageMixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def _mask_augmentation_modules(self, config: TrainConfig) -> list:
def _aspect_bucketing_in(self, config: TrainConfig, aspect_bucketing_quantization: int, frame_dim_enabled:bool=False):
Comment thread
maedtb marked this conversation as resolved.
Outdated
calc_aspect = CalcAspect(image_in_name='image', resolution_out_name='original_resolution')

aspect_bucketing_quantization = AspectBucketing(
aspect_bucketing = AspectBucketing(
quantization=aspect_bucketing_quantization,
resolution_in_name='original_resolution',
target_resolution_in_name='settings.target_resolution',
Expand All @@ -174,13 +174,14 @@ def _aspect_bucketing_in(self, config: TrainConfig, aspect_bucketing_quantizatio
target_resolutions_override_in_name='concept.image.resolution_override',
scale_resolution_out_name='scale_resolution',
crop_resolution_out_name='crop_resolution',
possible_resolutions_out_name='possible_resolutions'
possible_resolutions_out_name='possible_resolutions',
quantization=aspect_bucketing_quantization,
)

modules = [calc_aspect]

if config.aspect_ratio_bucketing:
modules.append(aspect_bucketing_quantization)
modules.append(aspect_bucketing)
else:
modules.append(single_aspect_calculation)

Expand Down
2 changes: 1 addition & 1 deletion requirements-global.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pooch==1.8.2
open-clip-torch==2.32.0

# data loader
-e git+https://github.com/Nerogar/mgds.git@a0c84a3#egg=mgds
-e git+https://github.com/Nerogar/mgds.git@TODO_PLACEHOLDER_CHANGE_ME_IF_PR_LANDS#egg=mgds

# optimizers
dadaptation==3.2 # dadaptation optimizers
Expand Down