Skip to content

fix(web): resolve stylelint errors in bulk-messages page#902

Merged
AchoArnold merged 2 commits into
mainfrom
fix/bulk-messages-stylelint
May 22, 2026
Merged

fix(web): resolve stylelint errors in bulk-messages page#902
AchoArnold merged 2 commits into
mainfrom
fix/bulk-messages-stylelint

Conversation

@AchoArnold
Copy link
Copy Markdown
Member

Fixes the CI lint failure on main caused by stylelint errors in \pages/bulk-messages/index.vue:

  • Added empty line before .clickable-row:hover\ rule (
    ule-empty-line-before)
  • Converted
    gba(0, 0, 0, 0.04)\ to modern notation
    gb(0 0 0 / 4%)\ (\color-function-notation\ + \�lpha-value-notation)

- Add empty line before rule as required by rule-empty-line-before
- Use modern color-function notation rgb(0 0 0 / 4%) instead of rgba(0, 0, 0, 0.04)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026

Greptile Summary

This PR fixes two stylelint rule violations in the <style> block of web/pages/bulk-messages/index.vue that were causing CI failures on main. The visual rendering of the hover background is unchanged — rgba(0, 0, 0, 0.04) and rgb(0 0 0 / 4%) are semantically identical.

  • Added an empty line before .clickable-row:hover to satisfy the rule-empty-line-before stylelint rule.
  • Rewrote the background color from legacy rgba() notation to modern rgb() slash notation to satisfy the color-function-notation and alpha-value-notation stylelint rules.

Confidence Score: 5/5

This PR is safe to merge — it only touches two lines in a scoped CSS block with no runtime or functional impact.

Both changes are purely stylistic linting corrections. The color values are semantically equivalent, and adding an empty line between CSS rules has no effect on rendering or behavior.

No files require special attention.

Important Files Changed

Filename Overview
web/pages/bulk-messages/index.vue Two stylelint fixes in the scoped <style> block: added required empty line before .clickable-row:hover and converted rgba(0,0,0,0.04) to modern rgb(0 0 0 / 4%) notation. No functional change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI Lint Check on main] -->|Stylelint errors detected| B[Failure]
    B --> C[PR 902: Fix stylelint errors]
    C --> D[Add empty line before hover rule]
    C --> E[Convert to modern rgb notation]
    D --> F[CI Lint Check passes]
    E --> F
Loading

Reviews (1): Last reviewed commit: "fix(web): resolve stylelint errors in bu..." | Re-trigger Greptile

- Split workflow into 'validate' (lint, test, build) and 'deploy' jobs
- Validate runs on both pull_request and push to main
- Deploy only runs after merge to main, gated behind validate passing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread .github/workflows/web.yml
Comment on lines 17 to 46
@@ -37,8 +40,26 @@ jobs:
- name: Run tests 🧪
run: pnpm test

- name: Debug 🐛
run: echo GITHUB_SHA=${GITHUB_SHA}
- name: Build 🏗️
run: mv .env.production .env && echo GITHUB_SHA=${GITHUB_SHA} >> .env && pnpm run generate

deploy:
name: Deploy
needs: validate
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest

steps:
- name: Checkout 🛎
uses: actions/checkout@master

- uses: pnpm/action-setup@v6
name: Install pnpm
with:
version: 10

- name: Install dependencies 📦
run: pnpm install

- name: Build 🏗️
@AchoArnold AchoArnold merged commit dc0a0f6 into main May 22, 2026
7 of 8 checks passed
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants