Migrate ExceededOrThresholdMarkerJexlNodeTest to AbstractQueryTest#3683
Open
apmoriarty wants to merge 1 commit into
Open
Migrate ExceededOrThresholdMarkerJexlNodeTest to AbstractQueryTest#3683apmoriarty wants to merge 1 commit into
apmoriarty wants to merge 1 commit into
Conversation
Same shape as ContentFunctionQueryTest: clones a per-test ShardQueryLogic to vary ivarator/threshold settings, so getLogic() returns a mutable currentLogic field. executeQuery() and getSettings() are overridden the same way (DefaultEvent results via getTransformIterator(), fixed non-yyyyMMdd date format). The getQueryRanges() plan-inspection helper (used by two tests to assert on pushdown range structure, independent of query execution) is kept as a self-contained method using the original 4-arg ShardQueryConfiguration.create()+initialize() flow, since it doesn't go through AbstractQueryTest's execute/assert machinery at all. Ingest already called IndexIngestUtil with a single fixed dataset (no range concept), so no ingest changes needed. All 8 tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lbschanno
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same shape as ContentFunctionQueryTest: clones a per-test ShardQueryLogic to vary ivarator/threshold settings, so getLogic() returns a mutable currentLogic field. executeQuery() and getSettings() are overridden the same way (DefaultEvent results via getTransformIterator(), fixed non-yyyyMMdd date format). The getQueryRanges() plan-inspection helper (used by two tests to assert on pushdown range structure, independent of query execution) is kept as a self-contained method using the original 4-arg ShardQueryConfiguration.create()+initialize() flow, since it doesn't go through AbstractQueryTest's execute/assert machinery at all.
Ingest already called IndexIngestUtil with a single fixed dataset (no range concept), so no ingest changes needed. All 8 tests pass.