Task/migrate grouping required filter functions test#3682
Draft
apmoriarty wants to merge 3 commits into
Draft
Conversation
…ryTest Uses ShardQueryLogic (EventQuery bean), extends AbstractQueryTest. Results are a DefaultEventQueryResponse (not raw Documents), so executeQuery() is overridden the same way as the original's getQueryResponse() helper. ShardRange/DocumentRange split dropped in favor of a single DOCUMENT-range ingest (GroupingFiltersIngest already calls IndexIngestUtil internally). Empirically, the IndexIngestUtil-derived NO_UID_INDEX/TRUNCATED_INDEX tables don't correctly locate results for this dataset's field-indexed (non-full-table-scan) queries, so getIndexTableNames() is narrowed to the raw SHARD_INDEX only, matching the precedent set by IvaratorInterruptTest for narrowing index table variants when derived tables don't apply. All 5 tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lbschanno
previously approved these changes
Jul 10, 2026
The scan authorization used by IndexIngestUtil.write() to build the
NO_UID_INDEX/TRUNCATED_INDEX/day/year index variants from SHARD_INDEX was
Authorizations("ALL") only, but every SHARD_INDEX entry in this dataset is
written with a compound visibility of ALL&E or ALL&I. That mismatch meant
the derived-table scan couldn't see any of the source rows, leaving the
derived index tables effectively empty for this fixture and causing the
equality-lookup tests to return zero events whenever a derived table was
selected. Widening auths to ALL,E,I fixes the derivation, so the
getIndexTableNames() override that narrowed
GroupingRequiredFilterFunctionsIntegrationTest to the raw SHARD_INDEX table
is no longer needed and is removed; all 5 tests now pass against every
index table variant.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.